Add ACKEE_BASEURL configuration.#317
Open
dodedodo wants to merge 5 commits intoelecterious:masterfrom
Open
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @electerious on Vercel. @electerious first needs to authorize it. |
Closed
Author
|
I've added an automatic redirect from I also noticed I forgot to update the healthcheck.js url's. |
Author
|
Hello @electerious, have you had time to check my work? If there's anything I can do to get this pull accepted please let me know 👍 . I also just saw the other pull request for a base URL option (#288). I honestly did not see that before. I'm not trying to step on anyone toes, and I'm sure either of these pulls will do the job just fine 🙂. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @electerious,
I took a jab at implementing some sort of base URL support. Can you give this a test run and tell me what you think?
I wrote some documentation as well.
One downside of this implementation is that withACKEE_BASEURL=/ackeethe server listens onexample.com/ackee/, but not atexample.com/ackee. This is because the relative paths need the trailing/(at least, I think so. Couldn't get it to work otherwise). It's not a breaking bug, and it's easily solved by configuring a http redirect from/ackeeto/ackee/in your reverse proxy. Maybe we could include that redirect directly in server.js?The above is now fixed.